feat: add support for apisix backend mode#181
Merged
Conversation
Contributor
conformance test reportapiVersion: gateway.networking.k8s.io/v1
date: "2025-06-25T10:52:20Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
failedTests:
- HTTPRouteCrossNamespace
- HTTPRouteInvalidBackendRefUnknownKind
result: failure
skippedTests:
- HTTPRouteHTTPSListener
statistics:
Failed: 2
Passed: 30
Skipped: 1
name: GATEWAY-HTTP
summary: Core tests failed with 2 test failures. |
Contributor
conformance test reportapiVersion: gateway.networking.k8s.io/v1
date: "2025-06-25T10:08:13Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
result: partial
skippedTests:
- HTTPRouteHTTPSListener
statistics:
Failed: 0
Passed: 32
Skipped: 1
name: GATEWAY-HTTP
summary: Core tests partially succeeded with 1 test skips. |
ronething
reviewed
Jun 25, 2025
AlinsRan
reviewed
Jun 25, 2025
| if apiv2.Is(obj) { | ||
| return nil | ||
| } | ||
| case BackendModeAPISIX: |
ronething
reviewed
Jun 25, 2025
ronething
reviewed
Jun 25, 2025
dspo
commented
Jun 25, 2025
ronething
reviewed
Jun 25, 2025
| kubectlOpts := k8s.NewKubectlOptions("", "", opts.Namespace) | ||
|
|
||
| if framework.ProviderType == adc.BackendModeAPISIX { | ||
| opts.ServiceName = "apisix" |
Contributor
There was a problem hiding this comment.
why serviceName should be fixed?
Contributor
Author
There was a problem hiding this comment.
其实不是必要的。但打印日志中 ServiceName 是 "apisix-standalone" 的话那么一瞬间有点令人误解，怀疑是不是自己 ProviderType 没写对。所以改一下。
ronething
reviewed
Jun 25, 2025
Contributor
There was a problem hiding this comment.
filename can be changed.
AlinsRan
reviewed
Jun 25, 2025
AlinsRan
approved these changes
Jun 25, 2025
ronething
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Support backend mode
apisix.Pre-submission checklist: